fix(obs-studio): reject NaN in validate_range - #396
Merged
Conversation
NaN bypassed min/max checks because NaN comparisons are always false, so invalid opacity/volume values could be stored. Reject non-finite floats before the range compare.
santhreal
requested review from
omerarslan0,
yuh-yang and
zhangxilong-43
as code owners
July 19, 2026 00:59
github-actions
Bot
added
the
existing-cli-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_rangeis used for opacity, volume, and similar bounded floats.NaNmade both min and max comparisons false, so the value was accepted and could be written into project JSON.Non-finite values are now rejected before the range check.
Repro:
validate_range(float("nan"), 0.0, 1.0, "Opacity")returnednanon main and now raisesValueError.